VMR: Use pipelineArtifact upload method for final join outputs #45221
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to mutate these artifacts anymore so we can move to the recommended pipelineArtifact upload method.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
reviewed
Nov 29, 2024
Comment on lines
+1392
to
1396
| - output: pipelineArtifact | ||
| targetPath: $(Build.ArtifactStagingDirectory)/artifacts/MergedManifest.xml | ||
| artifactName: AssetManifests | ||
| displayName: Publish Merged Manifest | ||
| sbomEnabled: false |
There was a problem hiding this comment.
Every job writes into the AssetManifests folder. Does that work with a pipeline artifact?
There was a problem hiding this comment.
no they don't, we only write into the VerticalManifests artifact in the VMR build.
|
Pavel said he prefers keeping the step as is for now, it'll be changed later anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know we don't need to mutate these artifacts anymore so we can move to the recommended pipelineArtifact upload method.