Chore: Update commander.js dependency #1255
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbartho
reviewed
Mar 16, 2022
package.json
Outdated
| @@ -71,7 +71,8 @@ | |||
| "docs:cp_defs": "mkdir docs/docs_generate; cp source/danger.d.ts docs/docs_generate; cp node_modules/@octokit/rest/index.d.ts docs/docs_generate/github.d.ts", | |||
| "docs": "yarn run docs:cp_defs; yarn typedoc --ignoreCompilerErrors --mode modules --json docs/js_ref_dsl_docs.json --includeDeclarations source", | |||
| "dts-lint": "yarn run declarations && yarn dtslint types", | |||
| "danger:prepush": "yarn build:fast; yarn test:fixtures; node distribution/commands/danger.js local --base main --dangerfile dangerfile.lite.ts" | |||
| "danger:local": "node distribution/commands/danger.js local --base main --dangerfile dangerfile.lite.ts", | |||
| "danger:prepush": "npm-run-all build:fast test:fixtures danger:local" | |||
There was a problem hiding this comment.
Do we really need this npm-run-all dependency? Is it just to have a lighter-weight syntax to run multiple commands?
yarn --silent build:fast && yarn --silent test:fixtures && yarn --silent danger:local seems to produce the same result without adding a new dependency, unless I’m missing something?
There was a problem hiding this comment.
this PR is based on changes from #1254 branch
|
This is now blocked on the "engine" keyword, as I'm not sure to what version we can update here. see discussion: |
glensc
force-pushed
the
commander-update
branch
from
3fbe1cd
to
56f0100
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Breaking points:
Skipped because this.opts() change seems too much right now: