Specify engine required by this package

[glensc]

Needed to set baseline when updating dependencies:

• Print default base branch for danger local #1251 (comment)

The version was chosen based on @types/node in package.json

[orta]

Looks reasonable to me, thanks

[glensc]

So, now that it's enforced, appears that installed packages are not compatible.

should downgrade the packages?

danger-js ☸ test(main) ➜ yarn
yarn install v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "10.24.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
danger-js ☸ test(main) ➜ yarn --production
yarn install v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "10.24.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
danger-js ☸ test(main) ➜

[glensc]

I've tried to downgrade, but still haven't reached a point where it is satisfied.

and probably want tooling to be several versions old?

➜ yarn add --dev '@typescript-eslint/parser@<5' 'eslint@<8' 'eslint-plugin-jest@<25' 'eslint-plugin-jsdoc@<34' '@typescript-eslint/eslint-plugin@<5.8'  'comment-parser@<1.2.0'
yarn add v1.22.17
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 12.0.0". Got "10.24.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

[fbartho]

@glensc imho, it’s impractical to support node <14 at this point. Even our testing can’t really support it due to interlocking dependencies in various places.

In this PR: #1189 I was forced to move us to only explicitly supporting >= node 14 in our test environment.

Please don’t downgrade any dependencies we have.

[fbartho]

Also It’s possible our @types/node expression should be >= node 10 to express that we only rely on features introduced in node 10, rather than a carat-based (^) expression which implies “only supports semver-compatible node versions” which is actually a stricter implication than what we mean.

[glensc]

I need a decision what is the minimum node version to proceed on this pr:

• Chore: Update commander.js dependency #1255 (comment)

and the decision should be marked with "engine" keyword.

[glensc]

If you say:

Please don’t downgrade any dependencies we have.

then the only option I see is to bump the engine to >=14, shall I send PR?

[orta]

14 should be fine, it reflects what we're running on CI

[glensc]

there: #1257