tests/setuid: add clevis-luks-udisks2 to allow list #3202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clevis-luks-udisks2` shipped as a subpackage of clevis have the setuid bit set [1]. I am not sure why this is failing only now since it's been enabled for a long time. [1]: https://gitlab.com/redhat/centos-stream/rpms/clevis/-/commit/ca4761025e6332e6d0e148f59833506b1f6b7470#4b7d5bd4b543f32d3da8004f4e1de346e6a2c2c9_0_184 Also see openshift/os#1631 (comment)
|
let's make sure |
+1 - if it is actually needed then this test update LGTM |
dustymabe
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clevis-luks-udisks2shipped as a subpackage of clevis have the setuid bit set 1.I am not sure why this is failing only now since it's been enabled for a long time.
Also see openshift/os#1631 (comment)