DNM: test PR with clevis-pin + fixed setuid test + revert c9s selinux patches #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ba8b71. All the issues here should be fixed by selinux-policy-38.1.44-1.el9 according to the linked tickets. So we shouldn't need this anymore.
Latest clevis pulls in opensc and pcsc-lite which gives this error on booting: ``` [ 1.931395] dracut-initqueue[621]: pcscd: unrecognized option '--disable-polkit' [ 1.742582] dracut-initqueue[621]: pcscd: unrecognized option '--disable-polkit' [ 1.933525] dracut-initqueue[621]: Usage: pcscd options [ 1.933837] dracut-initqueue[621]: Options: [[0;32m OK [[ 1.934124] dracut-initqueue[621]: -a, --apdu log APDU commands and results 0m] Found device [0;1;39mAmazon Elastic Block Store root[0m.[ 1.934449] dracut-initqueue[621]: -c, --config path to reader.conf [ 1.934737] dracut-initqueue[621]: -f, --foreground run in foreground (no daemon), [ 1.935028] dracut-initqueue[621]: send logs to stdout instead of syslog [ 1.935341] dracut-initqueue[621]: -T, --color force use of colored logs [ 1.935628] dracut-initqueue[621]: -h, --help display usage information [ 1.935912] dracut-initqueue[621]: -H, --hotplug ask the daemon to rescan the available readers [[0;32m OK [0m] Reached target [0;1;39mInit[ 1.936468] dracut-initqueue[621]: -v, --version display the program version number rd Root Device[[ 1.936748] dracut-initqueue[621]: -d, --debug display lower level debug messages 0m. [ 1.937028] dracut-initqueue[621]: -i, --info display info level debug messages [ 1.937316] dracut-initqueue[621]: -e --error display error level debug messages (default level) [ 1.937834] dracut-initqueue[621]: -C --critical display critical only level debug messages [ 1.938109] dracut-initqueue[621]: --force-reader-polling ignore the IFD_GENERATE_HOTPLUG reader capability [ 1.938665] dracut-initqueue[621]: -t, --max-thread maximum number of threads (default 200) [ 1.938948] dracut-initqueue[621]: -s, --max-card-handle-per-thread maximum number of card handle per thread (default: 200) [ 1.939509] dracut-initqueue[621]: -r, --max-card-handle-per-reader maximum number of card handle per reader (default: 200) [ 1.940064] dracut-initqueue[621]: -x, --auto-exit pcscd will quit after 60 seconds of inactivity [ 1.940632] dracut-initqueue[621]: -S, --reader-name-no-serial do not include the USB serial number in the name ``` This addresses openshift#1630 until https://issues.redhat.com/browse/RHEL-61612 has been fixed.
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@jbtrystram: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the following:
#1568 ( revert c9s selinux patches, failing due to https://issues.redhat.com/browse/RHEL-61612 )
#1631 - fixing the issue with clevis - RHEL-61612
coreos/fedora-coreos-config#3202 - Fixing the setuid test failure in #1631