Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Draft) Updated cc-role-definitions dependency (#155) #10473

Open
wants to merge 3 commits into
base: 7.8.0
Choose a base branch
from
+20 −4
Open

(Draft) Updated cc-role-definitions dependency (#155) #10473

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccecda4
Updated cc-role-definitions dependency (#155)
hrishabhg Oct 14, 2024
8a84352
updated version
hrishabhg Oct 15, 2024
50ba464
unpinned version
hrishabhg Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
<jersey-common>2.39.1</jersey-common>
<multi-threaded-testing.forkCount>3</multi-threaded-testing.forkCount>
<kafka.version>${ce.kafka.version}</kafka.version>
<cc.role.definitions.version>0.27.0</cc.role.definitions.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -463,6 +464,17 @@
<groupId>io.confluent</groupId>
<artifactId>broker-plugins</artifactId>
<version>${kafka.version}</version>
<exclusions>
<exclusion>
<groupId>io.confluent</groupId>
<artifactId>cc-role-definitions</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>cc-role-definitions</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need cc-role-definitions jar in ksql docker image? 🤔
we see this was introduced only in 7.8.x and comes in as transitive dependency..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this but it is runtime dependency for broker-plugins. If we will not include, something might break at runtime due to missing implementation.

https://staging-packages.confluent.io/maven/io/confluent/broker-plugins/7.8.0-ce/
https://staging-packages.confluent.io/maven/io/confluent/broker-plugins/7.8.0-ce/#:~:text=ce.module.sha512-,broker%2Dplugins%2D7.8.0%2Dce.pom,-broker%2Dplugins%2D7.8.0

<version>${cc.role.definitions.version}</version>
</dependency>

<!-- End Confluent dependencies -->
Expand Down Expand Up @@ -749,10 +761,16 @@
<groupId>io.confluent</groupId>
<artifactId>logredactor</artifactId>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>broker-plugins</artifactId>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>broker-plugins</artifactId>
<exclusions>
<exclusion>
<groupId>io.confluent</groupId>
<artifactId>cc-role-definitions</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>

<build>
Expand Down