Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Draft) Updated cc-role-definitions dependency (#155) #10473

Open
wants to merge 3 commits into
base: 7.8.0
Choose a base branch
from

Conversation

hrishabhg
Copy link
Member

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@hrishabhg hrishabhg requested a review from a team as a code owner October 14, 2024 14:54
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>cc-role-definitions</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need cc-role-definitions jar in ksql docker image? 🤔
we see this was introduced only in 7.8.x and comes in as transitive dependency..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrishabhg hrishabhg changed the title Updated cc-role-definitions dependency (#155) (Draft) Updated cc-role-definitions dependency (#155) Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants