-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save ComicBookInfo metadata when save as CBZ #235
base: master
Are you sure you want to change the base?
Conversation
Sorry for the late reply, I checked the regexp use some random gallery names and found some failed titles (image set and cosplay may be a big problem, since their names may not follow the common rules):
Should we fix these special cases? |
跑了大概有20多页吧。 |
从标题中能做的大概就只有这些了。 |
上面的这些应该还好,我指的是一些错误匹配的内容。其实更改后的脚本我没有试过,但是正则我放到 regex101 上测试了。感觉上面我列出来的这些会错误匹配(是从匹配的颜色上判断的),例如:
当然上面的只是一些特殊的错误的 case,大部分应该是都能正常匹配上的,不如说,完全没匹配(比如 cosplay 一般会按照 |
Hello any plans for this to be implemented? Would really love this functionality |
Should be merged once #235 (comment) resolved. I may work on it a few days later but don't expect too much 🤥 Or if you don't want to wait, you can clone his repo or download the zip file directly, then run the |
Hello I tried doing it as you said, and the user script updates to 1.3.5 but there is no option in the UI to select that option - only the standard info.txt, zip comment and none. Tried restarting and all but no avail, could u point out how to enable the option? Thank you very much |
var getZipComment = function () {
if (setting['save-as-cbz']) {
return JSON.stringify(getMetadataInZipComment(infoObj, infoStr))
} else if (setting['save-info'] === 'comment') {
return infoStr.replace(/\n/gi, '\r\n')
} else {
return undefined
}
} Seems that it should work once you enabled Save the zip file as CBZ? |
From the source code, I don't think it'll create such file. Instead this PR wrote the JSON formatted metadata into Zip comment. Maybe your software doesn't support this method to embed metadata? |
oh, I guess thats calibre exclusive usage then since Lanraragi, Kavita (Self Hosted Manga/Doujin Reader) and few more I have actually do need the ComicInfo.xml file in archive tor read. :( |
When saving to CBZ format, ComicBookInfo metadata is also saved.
It is convenient for manga readers and e-book management software (such as Caliber) to manage and identify.
Without metadata
With metadata