support generating ComicInfo.xml #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComicInfo.xml has been used by Komga and Kavita etc..
The document is at https://anansi-project.github.io/docs/category/comicinfo
Note this is different from #235, ComicInfo.xml is a XML file.
Regarding the title generation issue in #235, I directly use the title or title_jpn without parsing because that's what we see on E-hentai.
We should not over-parse, people can process it later if needed.
As there is no consensus for element SubTitle in ComicInfo.xml yet (see anansi-project/comicinfo#8 , anansi-project/comicinfo#4 , anansi-project/comicinfo#16 , anansi-project/comicinfo#6 ), I use title_jpn for
Titleif available.And I leave an extra element
EHD_infoto store the legacy info, so that people can process it later. (Note thatEHD_infowill have more information than the standard ComicInfo.xml)For example, add SubTitle to ComicInfo.xml if there is a consensus in the future.