FIX: Exclude non-Hashables from set in .get(return_type='id')

[adelavega]

Fixing a bug I introduced in #942

The problem is that just getting the raw .entities variable from a BIDSFile will return everything, including meta-data (which is arguably a design flaw).

The problem if anywhere in the meta-data you use the same name as a BIDS entity (in my case it was task), its returns will also be returned.

This simple fix check if at least the input to set is not Hashable, to prevent an error (although it will still return something funky if a non-hashable result from meta-data sneaks in).

[codecov]

Codecov Report

Base: 86.35% // Head: 86.35% // No change to project coverage 👍

Coverage data is based on head (d233e3e) compared to base (18778c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files          35       35           
  Lines        4023     4023           
  Branches      974      973    -1     
=======================================
  Hits         3474     3474           
  Misses        355      355           
  Partials      194      194           

Impacted Files	Coverage Δ
bids/layout/layout.py	88.10% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adelavega]

Oh-- ideally this should be added to the tests (by adding a hashable key that looks like an entity to a dataset). it's possible this breaks other tests as well.

This also related to Oscar's #684