-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reports module in favor of pybids-reports namespace package #814
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 86.31% // Head: 85.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 86.31% 85.59% -0.72%
==========================================
Files 35 30 -5
Lines 4033 3665 -368
Branches 976 903 -73
==========================================
- Hits 3481 3137 -344
+ Misses 356 348 -8
+ Partials 196 180 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
OK so the pybids-reports has been released so we can now think of how to take it out of pybids proper. @effigies do you want to go though a deprecation cycle for a couple of releases before we remove it with a warning to let people know about the new package? |
Ah, we should probably get back to this. |
Closes #801. This PR removes everything related to the
reports
module, since we will move to using a namespace package calledpybids-reports
. This will remain a draft until I've addressed the to-do list below.To do:
pybids-reports
(tracking with Release and push to PyPi pybids-reports#17)pybids