Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reports module in favor of pybids-reports namespace package #814

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 11, 2022

Closes #801. This PR removes everything related to the reports module, since we will move to using a namespace package called pybids-reports. This will remain a draft until I've addressed the to-do list below.

To do:

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Base: 86.31% // Head: 85.59% // Decreases project coverage by -0.72% ⚠️

Coverage data is based on head (6c0c484) compared to base (af095cc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   86.31%   85.59%   -0.72%     
==========================================
  Files          35       30       -5     
  Lines        4033     3665     -368     
  Branches      976      903      -73     
==========================================
- Hits         3481     3137     -344     
+ Misses        356      348       -8     
+ Partials      196      180      -16     
Impacted Files Coverage Δ
bids/__init__.py 100.00% <ø> (ø)
bids/utils.py 67.36% <0.00%> (-18.95%) ⬇️
bids/layout/models.py 91.08% <0.00%> (-0.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies added this to the 0.16.0 milestone Jul 22, 2022
@tsalo tsalo self-assigned this Dec 12, 2022
@Remi-Gau
Copy link
Contributor

OK so the pybids-reports has been released so we can now think of how to take it out of pybids proper.

@effigies do you want to go though a deprecation cycle for a couple of releases before we remove it with a warning to let people know about the new package?

@effigies
Copy link
Collaborator

Ah, we should probably get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Consider moving reports to its own repository
3 participants