-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding write_derivative_description and the related test #811
Draft
Remi-Gau
wants to merge
11
commits into
bids-standard:master
Choose a base branch
from
Remi-Gau:write_derivative_description
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Adding write_derivative_description and the related test #811
Remi-Gau
wants to merge
11
commits into
bids-standard:master
from
Remi-Gau:write_derivative_description
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 85.78% 85.57% -0.21%
==========================================
Files 34 34
Lines 3868 3909 +41
Branches 994 1009 +15
==========================================
+ Hits 3318 3345 +27
- Misses 353 362 +9
- Partials 197 202 +5
Continue to review full report at Codecov.
|
@Remi-Gau Is this still WIP or ready for review? |
Sorry. Still WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had to write twice some code to handle writing
dataset description
, so I think I had better brings back #552 from the grave.force
option to overwrite content