Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding write_derivative_description and the related test #811

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jan 29, 2022

I have had to write twice some code to handle writing dataset description, so I think I had better brings back #552 from the grave.

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #811 (1af6978) into master (0f460a8) will decrease coverage by 0.20%.
The diff coverage is 60.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   85.78%   85.57%   -0.21%     
==========================================
  Files          34       34              
  Lines        3868     3909      +41     
  Branches      994     1009      +15     
==========================================
+ Hits         3318     3345      +27     
- Misses        353      362       +9     
- Partials      197      202       +5     
Impacted Files Coverage Δ
bids/layout/utils.py 79.74% <60.97%> (-20.26%) ⬇️
bids/layout/validation.py 80.95% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f460a8...1af6978. Read the comment docs.

@effigies
Copy link
Collaborator

@Remi-Gau Is this still WIP or ready for review?

@Remi-Gau
Copy link
Contributor Author

Sorry. Still WIP

@adelavega adelavega marked this pull request as draft September 19, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants