[feature] allow specifying custom reqwest client #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows oneio::get_http_reader function to take an optional opt_client instead of headers, allowing more flexibility on customizing HTTP reqwest instead of only allowing changing headers. It is now library users' responsibility to create custom `reqwest::blocking::Client` for any request customizations. This commit has a couple of breaking changes: 1. rename `oneio::get_remote_reader` to `oneio::get_http_reader` 2. rename `get_remote_ftp_raw` to `get_ftp_reader_raw` 3. change signatures of `oneio::download`, `oneio::download_with_retry`, `oneio::get_http_reader`'s optional HashMap parameter for headers to optional `reqwest::blocking::Client`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows oneio::get_http_reader function to take an optional opt_client instead of headers, allowing more flexibility on customizing HTTP reqwest instead of only allowing changing headers.
It is now library users' responsibility to create custom
reqwest::blocking::Clientfor any request customizations.This PR has a couple of breaking changes:
oneio::get_remote_readertooneio::get_http_readerget_remote_ftp_rawtoget_ftp_reader_rawoneio::download,oneio::download_with_retry,oneio::get_http_reader's optional HashMap parameter for headers to optionalreqwest::blocking::Client.This PR resolves issue #52