Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] allow specifying custom reqwest client #53

Merged
merged 1 commit into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. allow custom reqwest client

    This commit allows oneio::get_http_reader function to take an optional
    opt_client instead of headers, allowing more flexibility on customizing
    HTTP reqwest instead of only allowing changing headers.
    
    It is now library users' responsibility to create custom
    `reqwest::blocking::Client` for any request customizations.
    
    This commit has a couple of breaking changes:
    1. rename `oneio::get_remote_reader` to `oneio::get_http_reader`
    2. rename `get_remote_ftp_raw` to `get_ftp_reader_raw`
    3. change signatures of `oneio::download`, `oneio::download_with_retry`,
    `oneio::get_http_reader`'s optional HashMap parameter for headers to
    optional `reqwest::blocking::Client`.
    digizeph committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ccd9fcb View commit details
    Browse the repository at this point in the history