fix(sequencer): grpc height hack to fix ibc invalid proof error #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
|
Please create the fork under the astriaorg organization and point this patch to https://github.com/astriaorg/penumbra |
|
@SuperFluffy done |
Fraser999
approved these changes
Nov 14, 2024
|
closing in favour of #1856 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
## Summary bump penumbra dep to commit with ibc height fix as it was merged upstream: penumbra-zone/penumbra@ac7abac ## Background see #1691 ## Changes - bump penumbra dep to commit with ibc height fix ## Testing it has been tested on the current live networks already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
patch penumbra temporarily so that height is passed from hermes's requests to the ibc grpc server.
Background
there was an IBC proof validation failure error on dusk-10. the computed app hash was one height after the expected app hash, which could be caused by the grpc queries always using the latest state snapshot, instead of at the height intended by hermes. however the grpc requests don't contain the height so the hack is to put the height in the grpc request metadata, which is then used by the grpc query server to use the correct snapshot.
this should probably be upstreamed into penumbra as this is actually the recommended solution by the ibc-go team (cosmos/ibc-go#7303)
Changes
Testing
ibc smoke test