-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump penumbra to 0.80.5 #1624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge the penumbra bits, but it's not clear why the celestia tendermint dependencies are having their versions decreased (neither sequencer nor penumbra have anything to do with those).
Cargo.lock
Outdated
@@ -1578,9 +1578,9 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "celestia-tendermint" | |||
version = "0.32.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going down for some reason - please fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was actually 0.32.1 in Cargo.toml - bumped the version there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary. Are you basing this patch on recent main
? The entry in Cargo.toml
indicates a minimum version. The entry in Cargo.lock
indicates the version we actually use.
I have just forked off recent main and updated the penumbra entries - celestia-tendermint
and celestia-tendermint-proto
are not affected by the penumbra change.
If you take the current main, do the penumbra changes there, and then regenerate Cargo.lock
you should get a clean patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased on top of main, reverted the last commit (for tendermint), and then restored && regenerated Cargo.lock. Now it does not contain tendermint changes.
Cargo.lock
Outdated
@@ -1607,9 +1607,9 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "celestia-tendermint-proto" | |||
version = "0.32.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one is going down.
closing because of #1691 for now - can bump penumbra once the height issue is figured out/upstreamed |
Summary
bump penumbra to latest release tag
Related Issues
closes #1390