Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test for latest Ruff version #284

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix failing test for latest Ruff version #284

merged 1 commit into from
Oct 17, 2023

Conversation

dhruvmanila
Copy link
Member

fixes: #282

@dhruvmanila dhruvmanila mentioned this pull request Oct 17, 2023
Closed
@dhruvmanila
Copy link
Member Author

dhruvmanila commented Oct 17, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@dhruvmanila dhruvmanila mentioned this pull request Oct 17, 2023
Merged
17 tasks
@dhruvmanila dhruvmanila reopened this Oct 17, 2023
@dhruvmanila dhruvmanila changed the base branch from dhruv/bump to main October 17, 2023 12:56
zanieb
zanieb approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun dataclass approach

@zanieb zanieb merged commit af6cf02 into main Oct 17, 2023
52 checks passed
@zanieb zanieb deleted the dhruv/fix-test branch October 17, 2023 13:55
@dhruvmanila dhruvmanila mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update test assertions for applicability levels to account for changes in Ruff v0.1.0
2 participants
@dhruvmanila @zanieb