Require ruff>=0.1.0
#283
Closed
Require ruff>=0.1.0
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 17, 2023
|
Can we avoid this? It'd be preferable to support an older version still and just toggle this behavior depending on the Ruff version (as we do for several other features) |
|
I guess it could be avoided but then the Notebook support will be available only if the user has v0.1.0. |
|
That seems preferable to me, but might be worth some more opinions. We opted for that approach in #266 |
|
Implementation is simple because it's just a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the minimum required version for Ruff to be
v0.1.0. This isbecause that version includes the
cellfield which will be used for JupyterNotebook support.