-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default known_only to parse_flags_with_usage #120
base: main
Are you sure you want to change the base?
Conversation
This would allow users to take advantage of the error handling here while still being able to pass custom options on to FLAGS. An alternative approach would just pass all `kwargs` along; but there's only one and this allows the docstring to stick here as well.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Makes sense. Could you please add a unit test, it will need similar setup as this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Actually make my reply a proper PR review)
Makes sense. Could you please add a unit test, it will need similar setup as this one
This would allow users to take advantage of the error handling here while still being able to pass custom options on to FLAGS.
An alternative approach would just pass all
kwargs
along; but there's only one and this allows the docstring to stick here as well.