Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change Symbols to Strings for input data" #720

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abelsiqueira
Copy link
Member

Reverts #711 as discussed. Let's see if the speedup is equivalent.

@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Benchmark Results

434fd43... e1c763c... 434fd43.../e1c763c0116d51...
energy_problem/create_model 0.13 ± 0.0071 h 0.127 ± 0.0079 h 1.02
energy_problem/input_and_constructor 15.3 ± 0.13 s 13.8 ± 0.1 s 1.11
time_to_load 2.9 ± 0.019 s 3.01 ± 0.056 s 0.963
434fd43... e1c763c... 434fd43.../e1c763c0116d51...
energy_problem/create_model 0.794 G allocs: 32.9 GB 0.794 G allocs: 32.8 GB 1
energy_problem/input_and_constructor 6.39 M allocs: 0.661 GB 6.39 M allocs: 0.674 GB 0.982
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (434fd43) to head (e1c763c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #720   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          768       770    +2     
=========================================
+ Hits           768       770    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant