Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor timeframes, assets, and flows to use DuckDB for input data #712

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

datejada
Copy link
Member

@datejada datejada commented Jul 31, 2024

Pull request details

Describe the changes made in this pull request

To use DuckDB instead of tablee

List of related issues or pull requests

Closes #710

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (434fd43) to head (1bb9612).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #712   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          768       769    +1     
=========================================
+ Hits           768       769    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada force-pushed the 710-refactor-tf-assets-input branch from 1a9afad to c329005 Compare July 31, 2024 17:52
@datejada datejada added the benchmark PR only - Run benchmark on PR label Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Benchmark Results

434fd43... 1bb9612... 434fd43.../1bb96129b41af5...
energy_problem/create_model 0.128 ± 0.0091 h 0.131 ± 0.0074 h 0.982
energy_problem/input_and_constructor 14.9 ± 0.11 s 15.1 ± 0.085 s 0.985
time_to_load 2.92 ± 0.033 s 3.07 ± 0.021 s 0.95
434fd43... 1bb9612... 434fd43.../1bb96129b41af5...
energy_problem/create_model 0.794 G allocs: 32.9 GB 0.794 G allocs: 32.9 GB 1
energy_problem/input_and_constructor 6.39 M allocs: 0.661 GB 6.41 M allocs: 0.663 GB 0.997
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@datejada datejada marked this pull request as ready for review July 31, 2024 20:13
@datejada datejada requested a review from suvayu July 31, 2024 20:13
Copy link
Member

@suvayu suvayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the default for get_table should be without Val(:raw), and to get a df pass Val(:df).

src/io.jl Outdated Show resolved Hide resolved
@datejada datejada requested a review from suvayu August 2, 2024 06:06
@datejada
Copy link
Member Author

datejada commented Aug 2, 2024

@suvayu, thanks for the review and suggestion 😄 I think we need to re-evaluate all these changes made during this week, given the results from the benchmarks in the latest PRs. @abelsiqueira has the PR #720 to compare performance. Let's review the big picture in the next meeting and decide how to continue.

@abelsiqueira abelsiqueira merged commit f6683a3 into main Aug 5, 2024
7 checks passed
@abelsiqueira abelsiqueira deleted the 710-refactor-tf-assets-input branch August 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor timeframe and assets data inputs to read from DuckDB
3 participants