-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor timeframes, assets, and flows to use DuckDB for input data #712
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 768 769 +1
=========================================
+ Hits 768 769 +1 ☔ View full report in Codecov by Sentry. |
1a9afad
to
c329005
Compare
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the default for get_table
should be without Val(:raw)
, and to get a df pass Val(:df)
.
Co-authored-by: Suvayu Ali <[email protected]>
@suvayu, thanks for the review and suggestion 😄 I think we need to re-evaluate all these changes made during this week, given the results from the benchmarks in the latest PRs. @abelsiqueira has the PR #720 to compare performance. Let's review the big picture in the next meeting and decide how to continue. |
Pull request details
Describe the changes made in this pull request
To use DuckDB instead of tablee
List of related issues or pull requests
Closes #710
Collaboration confirmation
As a contributor I confirm