Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dark mode #176

Merged
merged 31 commits into from
Oct 7, 2024
Merged

Conversation

Johnnyevans32
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR adds dark mode toggling.

Related Tickets & Documents

Resolves #76

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2024-10-04.at.18.42.07.mov

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Johnnyevans32
Copy link
Contributor Author

@leordev @acekyd @blackgirlbytes @finn-tbd ready for review

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good to me! Just want to make sure that folks who are experts on vue like @acekyd and folks who are experts on DWAs like @leordev think the same. But I think this is ready to merge!

@blackgirlbytes
Copy link
Contributor

Actually, I'm going to merge this to get some of the open PRs out of the way. It doesn't seem like there are any issues to me.

@blackgirlbytes blackgirlbytes merged commit 4262bbb into TBD54566975:main Oct 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode/light theme - Vue
2 participants