Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode/light theme - Vanilla.js #84 #320

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

29deepanshutyagi
Copy link
Contributor

issue #84

@29deepanshutyagi
Copy link
Contributor Author

and kindly labelled this issue as large instead of medium, as it's consist of various tasks

@taniashiba
Copy link
Contributor

and kindly labelled this issue as large instead of medium, as it's consist of various tasks

Hi there, thank you for sharing your PR! Our team will review it soon, and we will make sure to review and assign the weight according to our team. Thank you for your contribution! ❤️

@blackgirlbytes
Copy link
Contributor

blackgirlbytes commented Oct 17, 2024

Thanks for the contribution!
hmm @29deepanshutyagi what various tasks? let me know. It seems like you added tests and added dark mode/light mode which is required of the ticket.

Very similar to this PR -- which has 30 files changed adding dark mode and light mode for Vue project. It was weighed at medium #176

@29deepanshutyagi
Copy link
Contributor Author

yeah , i had done those tasks which are stated in issue ,

@29deepanshutyagi
Copy link
Contributor Author

kindly tell me , if there is any issue in this pr

@blackgirlbytes
Copy link
Contributor

@29deepanshutyagi I updated your PR to be a large, but I had to label the Vue version of this ticket as a large as well. To be fair.

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@blackgirlbytes blackgirlbytes merged commit bc9da6b into TBD54566975:main Oct 17, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants