Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] add docs to show API Platform implementation. #147
base: main
Are you sure you want to change the base?
[API] add docs to show API Platform implementation. #147
Changes from 4 commits
e63314a
b713e09
9cdbce5
eaf9a7f
bd2f8cc
d316a1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be easier to split this into 2 DTO objects - something like
RequestResetPasswordInput
andResetPasswordInput
. Then you can configure theinput
on each, specific operation i think (instead of having theinput=
on the top-level.Another option would be to create these 2 DTO's and make THEM each their own
@ApiResource
... each with 1 operation. I'm not sure if havingResetPasswordRequest
as the@ApiResource
is doing us any favors, as we never use it as the input or output. That would be my biggest potential feedback on this otherwise awesome effort.input
andoutput
DTO's are kind of an edge-case feature in API Platform... so if we can find a clean way to do this without them, that might ideal.