-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] add docs to show API Platform implementation. #147
base: main
Are you sure you want to change the base?
Conversation
TODO - Do not return a |
Routes:
Responses:
Responses: |
README.md
Outdated
* @Assert\NotBlank(groups={"putValidation"}) | ||
* @Groups({"reset-password:put"}) | ||
*/ | ||
public string $plainTextPassword; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be easier to split this into 2 DTO objects - something like RequestResetPasswordInput
and ResetPasswordInput
. Then you can configure the input
on each, specific operation i think (instead of having the input=
on the top-level.
Another option would be to create these 2 DTO's and make THEM each their own @ApiResource
... each with 1 operation. I'm not sure if having ResetPasswordRequest
as the @ApiResource
is doing us any favors, as we never use it as the input or output. That would be my biggest potential feedback on this otherwise awesome effort. input
and output
DTO's are kind of an edge-case feature in API Platform... so if we can find a clean way to do this without them, that might ideal.
This guide is incomplete and should not be used until after it is merged. Everything subject to change until then.
refs #128
Relates to symfony/maker-bundle#798