Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Closed caption keyvalues may not parse correctly in certain edge cases and spew garbage #1261

Open
pivotman319-owo opened this issue Nov 28, 2024 · 0 comments
Open

Bug: Closed caption keyvalues may not parse correctly in certain edge cases and spew garbage #1261

pivotman319-owo opened this issue Nov 28, 2024 · 0 comments
Labels
Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. Type: Bug This is a problem with something that should be working one way, but isn't. What: Audio Issues relating to the sound system What: Engine Engine related issues

Comments

@pivotman319-owo
Copy link
Member

pivotman319-owo commented Nov 28, 2024 •
edited
Loading

Describe the bug

Not exclusive to Strata engine branch. See ValveSoftware/Source-1-Games#6770

chaos_2024-11-28_20-10-21

raw failing closecaption kv in subtitles_english.dat, as of latest P2CE staging build:
glados.testchambermisc23 as-is in subtitles_english.dat

same failing closecaption kv in raw datafile (subtitles_english.txt):

        "glados.testchambermisc23"    "<clr:163,193,173><B>GLaDOS:<B> You know how I'm going to live forever, but you're going to be dead in sixty years? Well, I've been working on a belated birthday present for you. Well, more of a belated birthday medical procedure. Well, <I>technically,<I> it's a medical experiment. What's important is, it's a present!"

To Reproduce

  1. closecaption 1; cc_subtitles 1 in console
  2. map sp_a2_laser_relays
  3. solve the test chamber; alternatively, cc_emit glados.testchambermisc23 in console

Issue Map

Not Applicable

Expected Behavior

The CC kv value should be parsed and displayed correctly

Operating System

Windows 11 24H2 Dev Channel - 10.0.26100.2415 (ge_release_svc_betaflt_im.241116-1208) amd64fre
@pivotman319-owo pivotman319-owo added the Type: Bug This is a problem with something that should be working one way, but isn't. label Nov 28, 2024
@pivotman319-owo pivotman319-owo changed the title Bug: Closed-captions may not parse correctly in certain edge cases and spew garbage sometimes Bug: Closed caption keyvalues may not parse correctly in certain edge cases and spew garbage Nov 28, 2024
@pivotman319-owo pivotman319-owo added What: Engine Engine related issues Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. What: Audio Issues relating to the sound system labels Nov 28, 2024
@pivotman319-owo pivotman319-owo mentioned this issue Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. Type: Bug This is a problem with something that should be working one way, but isn't. What: Audio Issues relating to the sound system What: Engine Engine related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pivotman319-owo