Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Remove warn_unreachable=true from mypy config #301

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ukmo-ccbunney
Copy link
Contributor

🚀 Pull Request

Description

Small update to turn comment out the following:

[mypy] warn_unreachable=true

as that check is listed in the disable_error_code list for mypy.

This also requires the MY103 check adding to the ignore list in repo-review.

This was supposed to go into PR #293 , but it got merged before I could update.

the `disable_error_code` list. Required an ingore entry in repo-review.
Copy link

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit f1f332c into SciTools:main Nov 21, 2024
14 checks passed
@ukmo-ccbunney ukmo-ccbunney deleted the mypy_warn_unreachable branch November 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants