Skip to content

Commit

Permalink
Removed warn_unreachable=true from mypy as it is also being ignored…
Browse files Browse the repository at this point in the history
… in (#301)

the `disable_error_code` list. Required an ingore entry in repo-review.
  • Loading branch information
ukmo-ccbunney authored Nov 21, 2024
1 parent bc581bf commit f1f332c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ disable_error_code = [
"misc",
"no-untyped-call",
"no-untyped-def",
"unreachable",
"unreachable", # TODO: Uncomment `warn_unreachable` below when fixed
]
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
strict = true
warn_unreachable = true
# warn_unreachable = true # TODO: Enable once all unreachable code is fixed

[tool.numpydoc_validation]
checks = [
Expand Down Expand Up @@ -136,6 +136,7 @@ ignore = [

# TODO: exceptions that still need investigating are below.
# Might be fixable, or might become permanent (above):
"MY103", # Must have warn_unreachable enabled in mypy
"PY007", # Supports an easy task runner (nox or tox)
"PP309", # Filter warnings specified
"PC170", # Uses PyGrep hooks (only needed if rST present)
Expand Down

0 comments on commit f1f332c

Please sign in to comment.