-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for does the dog die warning labels operation #1913
base: nightly
Are you sure you want to change the base?
Conversation
56f7596
to
3c943ad
Compare
Missing doc updates additional I've tried running this locally: libraries:
Movies:
operations:
mass_does_the_dog_labels: dog
doesthedogdie:
apikey: 1234567890 and I get this:
|
@YozoraXCII I definitely will get on adding some docs, thats next on my list! I converted this to draft for now to indicate this is still a WIP. I have just pushed a change here, as PMM doesn't search for movies by title like doesthedogdie requires. We are able to match movies by title and year... but to add a level of customization here I added a I've also added a Regarding the error that you've gotten, as I've converted the Here is what my config looks like for the most recent push: libraries:
Movies:
operations:
mass_does_the_dog_labels:
strict_search: false
label_mode: dog
doesthedogdie:
apikey: abc123 Optionally could also include categories of topics like so: libraries:
Movies:
operations:
mass_does_the_dog_labels:
strict_search: false
label_mode: Animal,Abuse,Sexism,Addiction,Children
doesthedogdie:
apikey: abc123 Thanks for taking a look! |
Added docs... getting closer but still not sure if this is ready.. feel like |
We are looking at this in-house, part of the problem is the scraping of the data from 25,000-ish items. I'm not saying it won't happen, we're just trying to figure out the best way of dealing with it. |
c13e173
to
f108b79
Compare
16a01f7
to
f1aa2ed
Compare
e4a9ea7
to
9c9e301
Compare
Description
Hi there! Here is my first attempt at adding support for https://www.doesthedogdie.com/ warning labels as a mass operation.
I have ideas for additional functionality I'd like to add but as this is my very first PR to this project and it's not exactly "small" I thought it'd be a good idea to go ahead and get the PR started. Currently the code is usable.
mass_does_the_dog_labels
operation to execute (based on themass_imdb_parental_labels
code)doesthedogdie.py
all
orremove
to get all or nonedog
to get just the classic "does the dog die" labelLet me know what you think! And any guidelines around adding documentation and stuff. I could see the topic and category list being retrieved dynamically or being in a different file but I also see that convention seems to to usually be an external file in a github repo so not sure if that is something I should follow here. etc.
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
Checklist