build requirements + system packages before copying app code #1914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I was working on #1913 I noticed that the Dockerfile busted the cache on every code change because the code is copied, then the requirements are built and the system packages are installed.
A common technique is to copy the requirements files and install system packages (less likely to change) before application code (most likely to change).
Ideally, the system packages would be installed by themselves first, then the requirements, then copy the app code. Even with this improvement, a change in either python dependencies or system packages would cause both dependencies and packages to be re-installed.. but everything seems to be quite tangled and this change here will be far be the greatest decrease in average build time via the structure of the Dockerfile.
TLDR - This decreased my build time from a few minutes per build to a few seconds by taking advantage of Docker Layer Caching
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
Checklist