Send max prerelease version separately #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
HebaruSan
force-pushed
the
fix/max-prerelease
branch
from
1593016 to
aedb1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently multi-hosted mods with single-hosted prereleases end up with
Out-of-order version found on unreliable serverinflation errors because the version on the host without the prerelease is less than the prerelease.Changes
Now the
HighestVersionmessage attribute reflects non-prereleases only, which will resolve these inflation errors while temporarily opening a new potential functional issue where out-of-order prerelease versions might not be caught.A new
HighestVersionPrereleasemessage attribute now contains the highest version number of a prerelease for the given mod. A subsequent update in the Inflator will use this attribute to address the above gap. This PR will not be merged until that one is ready.