Don't raise inflation errors for single-hosted prereleases of multi-hosted mods #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prereleases currently get indexed, and then in subsequent passes an inflation error
Out-of-order version found on unreliable serveroccurs because only one host has the prerelease, and that host's latest release appears to be out of order by comparison.Changes
Now the Inflator has a
--highest-version-prereleaseparameter and supports aHighestVersionPrereleasemessage attribute (to be populated by KSP-CKAN/NetKAN-Infra#352) that can specify the version of the latest prerelease separately from the regular releases. When we check for out-of-order versions, regular releases are only compared to other regular releases, and prereleases are compared to both.Once both PRs are merged, the inflation errors associated with prereleases should drop off, which is important for minimizing the re-downloading of modules.