Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet #942

Merged
merged 40 commits into from
Jul 17, 2024
Merged

Fleet #942

merged 40 commits into from
Jul 17, 2024

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    34769dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1626ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bde0c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aaf9755 View commit details
    Browse the repository at this point in the history
  5. Fix tests

    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    686a8ed View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f0cbb84 View commit details
    Browse the repository at this point in the history
  7. Rename argument

    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    820411c View commit details
    Browse the repository at this point in the history
  8. Delegate handling closing keystrokes to implementations

    Sometimes it may mean aborting interception (CTRL-C), sometimes finishing it (CR)
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fe5d2a6 View commit details
    Browse the repository at this point in the history
  9. Create a Wrapper for ExEntryPanel

    ExEntryPanel already extends JPanel, so we need a wrapper to make it extend VimModalInputBase
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    98b62e4 View commit details
    Browse the repository at this point in the history
  10. Always register shortcuts

    No matter what kind of panel we have, we want VimShortcutKeyAction to be triggered and pass the shortcut keys (e.g. CTRL-C to close panel)
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    66bb7f1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c8cd390 View commit details
    Browse the repository at this point in the history
  12. Remove unnecessary write action

    `insertRegister` is self synchronized
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    198db5e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    93a98a6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e28083d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e1bda4d View commit details
    Browse the repository at this point in the history
  16. Fix VisualAreaMatcher

    It looks for the last selection info in all conditions, not the ones that were specified
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b2f706f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a1c9649 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    81afa16 View commit details
    Browse the repository at this point in the history
  19. Remove startExEntry method

    We may create a command line via the VimCommandLineService and forget (or do not know) about calling startExEntry necessary. So we move its logic inside the creation of the command line
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e358a38 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5cbb621 View commit details
    Browse the repository at this point in the history
  21. Remove shouldRecord from KeyConsumer

    shouldRecord value was only updated in ModeInputConsumer when the key was not handled. But when the key is not handled, it is not passed to finishedCommandPreparation and the shouldRecord value is not used
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1a02a22 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    ce687f6 View commit details
    Browse the repository at this point in the history
  23. ProcessSubstituteCommand refactoring part 2

    We do not need the `doAll` condition (because the next code block with `doAll` adjusts line and column for the next match to be correct),
    And the line2 can't be >= editor.lineCount()
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b254926 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    d8ffee1 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    4803b03 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    6289246 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    ab19ed6 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    4d92904 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    a5e4666 View commit details
    Browse the repository at this point in the history
  30. ProcessSubstituteCommand refactoring part 9

    Finally, moved confirmation dialog to modal input
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f6fd7fe View commit details
    Browse the repository at this point in the history
  31. Remove confirmChoice method

    It used secondary loop
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    789f2f2 View commit details
    Browse the repository at this point in the history
  32. Remove modal input on click

    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9f965b8 View commit details
    Browse the repository at this point in the history
  33. Remove typing in ModalInput

    Typing is more suitable for command lines than a modal input, and most likely it should be used instead
    It is still possible to support typing by properly implementing the handleKey method
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d111474 View commit details
    Browse the repository at this point in the history
  34. Remove isCancel argument

    It was not used anywhere
    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b2a24d3 View commit details
    Browse the repository at this point in the history
  35. Add comment

    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    91ab7a0 View commit details
    Browse the repository at this point in the history
  36. Fix compilation

    lippfi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1e1be95 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fix surround

    lippfi committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    385bd23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38e71f1 View commit details
    Browse the repository at this point in the history
  3. Safer getCurrentModalInput()

    lippfi committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7028587 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb47284 View commit details
    Browse the repository at this point in the history