Fleet #942
Merged
Fleet #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it may mean aborting interception (CTRL-C), sometimes finishing it (CR)
ExEntryPanel already extends JPanel, so we need a wrapper to make it extend VimModalInputBase
No matter what kind of panel we have, we want VimShortcutKeyAction to be triggered and pass the shortcut keys (e.g. CTRL-C to close panel)
`insertRegister` is self synchronized
It looks for the last selection info in all conditions, not the ones that were specified
We may create a command line via the VimCommandLineService and forget (or do not know) about calling startExEntry necessary. So we move its logic inside the creation of the command line
shouldRecord value was only updated in ModeInputConsumer when the key was not handled. But when the key is not handled, it is not passed to finishedCommandPreparation and the shouldRecord value is not used
We do not need the `doAll` condition (because the next code block with `doAll` adjusts line and column for the next match to be correct), And the line2 can't be >= editor.lineCount()
Finally, moved confirmation dialog to modal input
It used secondary loop
Typing is more suitable for command lines than a modal input, and most likely it should be used instead It is still possible to support typing by properly implementing the handleKey method
It was not used anywhere
AlexPl292
reviewed
Jul 12, 2024
| @NotNull | ||
| @Override | ||
| public VimInputInterceptor<?> getInputInterceptor() { | ||
| return myInputInterceptor; |
There was a problem hiding this comment.
myInputInterceptor is nullable, but the method is @NotNull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK after this commit the only Swing thing that will be left in IdeaVim is KeyStroke