Replace colorize with a simple internal implementation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Please do publish a new gem 👍 |
|
@hlascelles i've published a new gem, the version number is 0.11.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fasterer has been using the colorize gem for coloring output since it's inception, and to my surprise, more issues were opened related to it then i would expect. Given it's a simple implementation and we use a very small subset of features (color in red, color in green), here's an attempt to replace it with an internal implementation.
I would not be surprised if there is a bug or two that pops up for folks, but that's okay, we'll solve it and get rid of colorize.