Release v1.1.0 #1092
Merged
Release v1.1.0 #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build: updates version number * feat: adds qc schema json * fix: updates schema version check to handle new core schemas * ci: adds service account token to github actions * bump schema version [skip actions] * fix: updates broken github action * bump schema version [skip actions] * build: increments version to 1.0.0 * build: sets core metadata schema to v1.0.0 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* added EMGInsertion * lint * one_of * chore: lint * fix: removing ONE_OF calls for Union types * changed name --------- Co-authored-by: Dan Birman <[email protected]>
#1041) * chore: making all use of Field(default=None) consistent for Optional fields * chore: lint
* added Side * midline * schema version
…figures (#1037) * feat: refactor qc_metrics to a List of metrics, with additional metadata * fix: replace AindGenericType with typing.Any * feat/tests: making references optional but name required, fixing typo, trying to fix tests * tests: fixing broken quality_control example + tests * fix: add default= for Optional fields * tests: changing how examples are generated * refactor: QC.Stage and adding _name and _desc fields * fix: no shortened names, lint * chore: missed name changes
* fixed lick sensor * lint * updated reward spounts in rig session compat test * fixed name for daq channels * lint * lick sensor required * fip_ophys_rig example * test_device update * updated models
* Remove redundant discriminator * Fix type signature and length constrain * Linting * chore: un-capping pydantic version * Revert "chore: un-capping pydantic version" This reverts commit 2f81eda. --------- Co-authored-by: Dan Birman <[email protected]>
* Update quality_control.py * tests: fixing tests * tests: one more missing test
* feat: adding flake8 extension that checks for default= and ... Still needs work, this catches situations that it shouldn't catch * chore: missing default= * chore: realized there is a special linters section
* refactor: changing references -> reference * feat: add an overall evaluator name * feat: adding QCStatus and lists of status for versioning * chore: lint * tests: updating tests for QCStatus
* chore: un-cap pydantic version * fix: increasing pydantic floor to avoid model_construct() + Union issues * fix: specify versions to ignore * fix: moving version limits to [dev]
* docs: adding draft QC docs * docs: adding more qc docs * feat: add myst_parser and qc to index * refactor: replace .rst file with .md * docs: adding information about reference URLs * docs: separating portal information into an AIND section * docs: cleaning up documentation for qc * docs: more cleanup on qc docs * docs: small updates to docs based on discussion about credentials * docs: updating qc docs based on discussion * docs: cleaning up docs and clarifying in a few spots
* feat: adding optional ResourceUsage to DataProcess * tests: adding example * refactor: adding ResourceTimestamped * chore: remove timeunit * tests: adding tests * fix: missing Field() * chore: lint * chore: lint * tests: examples * chore: lint * refactor: date->datetime and usage_unit * chore: update processing example * chore: lint * fix: datetime -> AwareDatetime * refactor: rename memory to system_memory * chore: lint * tests: force timezones to utc for CI * fix: timezone issue for tests * refactor: remove MemoryValue and add validators for Optional unit fields * refactor: remove file_io * chore: lint * chore: lint * refactor: remove file_io * refactor: clean up validators into a single root validator * chore: lint * tests: fix examples, also allow float memory sizes * tests: update example file * chore: lint
…sed on metric states (#1074) * refactor: changing references -> reference * feat: add an overall evaluator name * feat: adding QCStatus and lists of status for versioning * chore: lint * tests: updating tests for QCStatus * feat: add QCStatus list to metrics * feat: adding a function to automate setting the evaluation_status field Coverage not at 100% yet Also replaced date with datetime in QCStatus * test: test coverage for overall_status * test: add coverage for properties * refactor: date -> datetime * chore: lint * doc: missing docstrings * tests: remove unnecessary test * feat: auto-set status when never previously evaluated, and tests * fix: fixing an issue with private attributes You can't do what I wanted (hide the _evaluation_status list) because pydantic doesn't serialize the field. So we have to keep the history exposed but we'll have to encourage people not to access it directly * chore: example and lint * fix: removing default_factory, trying to allow timestamp pass through * test: fixing examples test timestamp issue * chore: lint * refactor: datetime -> AwareDatetime and remove default * tests: add a test that confirms that order is preserved * fix: missing timezones for example * feat: add option to allow failures in metrics * feat: add a convenience function to get metrics that are failing * tests: update qc.json example * feat: ensure metric_status_history not empty with validator * chore: docstring * test: improving examples * chore: lint * feat: add asset_id field to qc * tests: fix examples * tests: fix examples * docs: extended desc for allowing failed metrics * feat: removing prefixes to clean up fields * feat: remove property prefixes * chore: lint * chore/tests: lint and fix examples * tests: fix refactor issues in tests * docs: fix typo * chore: unused import snuck in? * fix: allow none to return from failed_metrics * ci: fix for python 3.8 failures * fix: remove the confusing "Automated" evaluator * tests: fix qc example * refactor: removing redundant status_history from QualityControl and QCEvaluation * fix: forgot to remove redundant fields * tests: fix examples
* chore: version bump for schemas * tests: example updates
Main merge v110
jtyoung84
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.