Don't make duplicate PatternsMatcher instances. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 6 6
Lines 303 300 -3
==========================================
- Hits 300 297 -3
Misses 3 3
|
wRAR
commented
Apr 1, 2024
| @@ -35,7 +35,8 @@ def __init__(self, include: List[str], exclude: Optional[List[str]] = None, prio | |||
|
|
|||
| def get_domains(self) -> List[str]: | |||
| domains = [get_pattern_domain(pattern) for pattern in self.include] | |||
| return [domain for domain in domains if domain] | |||
| # remove duplicate domains preserving the order | |||
| return list(dict.fromkeys(domain for domain in domains if domain)) | |||
There was a problem hiding this comment.
I don't know if preserving the order is important but why not.
Gallaecio
approved these changes
Apr 1, 2024
BurnzZ
approved these changes
Apr 1, 2024
|
Would this remove the need for checking the uniqueness of the identifier? if matcher.identifier not in unique:
... |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10