Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SSL check #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Disable SSL check #5

wants to merge 9 commits into from

Conversation

sortafreel
Copy link

@sortafreel sortafreel commented Dec 29, 2021 •
edited
Loading

  • Allow enabling/disabling SSL certificate checks in sessions through TCPConnector.
  • Add mockserver with SSL support.
  • Add tests.

@Gallaecio
Copy link
Contributor

In which scenarios do we need this feature?

@Gallaecio Gallaecio requested a review from kmike May 17, 2022 08:36
@kmike
Copy link
Collaborator

kmike commented May 17, 2022

I think it's a port of zytedata/zyte-autoextract#37 to this library.

@Gallaecio
Copy link
Contributor

Should we consider the Zyte Smart Proxy Manager approach instead? They provide a downloadable CA certificate and installation instructions, so users can get things working without security compromises.

@kmike kmike added the inactive label Sep 26, 2022
@Gallaecio Gallaecio mentioned this pull request Aug 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike Awaiting requested review from kmike

Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sortafreel @Gallaecio @kmike