feat(config): add Namron 4512748 2A Awning Controller #7088
Conversation
First time in a long time doing this, so need some assistance/guidance to get it right
Last time testing, if it breaks again I'll install the environment...
I know what I said, this is the last time...
| { | ||
| "label": "Value=0", | ||
| "value": 0 | ||
| }, | ||
| { | ||
| "label": "Value=1", | ||
| "value": 1 | ||
| }, | ||
| { | ||
| "label": "Value=2", | ||
| "value": 2 | ||
| }, | ||
| { | ||
| "label": "Value=3", | ||
| "value": 3 | ||
| }, | ||
| { | ||
| "label": "Value=4", | ||
| "value": 4 | ||
| } |
There was a problem hiding this comment.
What do those values mean? "Value=3" isn't self-explanatory.
| "label": "Power Change Threshold Limit", | ||
| "valueSize": 1, | ||
| "defaultValue": 10 |
There was a problem hiding this comment.
This and the following parameters are missing:
- unit (can also be sth. like
"0.1 V") - mininum and maximum value
| }, | ||
| { | ||
| "#": "14", | ||
| "label": "Time Cycle To Report Energy Consumption Value", |
There was a problem hiding this comment.
We typically reword the labels to something more understandable, in this case:
| "label": "Time Cycle To Report Energy Consumption Value", | |
| "label": "Energy Report Interval", |
| }, | ||
| { | ||
| "#": "6", | ||
| "label": "Starting Positioning Calibration Performed", |
There was a problem hiding this comment.
This sounds like it indicates a status, but is writeonly?
| "paramInformation": [ | ||
| { | ||
| "#": "2", | ||
| "label": "Enable/Disable State Report Threshold", |
There was a problem hiding this comment.
Avoid using "Enable/Disable" in labels. Usually there is a better label, or the options already imply that they are meant for enabling or disabling something.
|
FWIW, I strongly recommend not doing this on Github itself, but rather offline in VSCode: |
First time in a long time doing this, so need some assistance/guidance to get it right
Solves issue #7087