Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug is solved, I have added the icon.png file #5909

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kanishka-coder0809
Copy link

@kanishka-coder0809 kanishka-coder0809 commented Nov 18, 2024

In the issue I have added the icon.png file in the images folder which is a sub folder in fastlane. Fix #5908

@licaon-kter
Copy link

please, move it to https://github.com/zulip/zulip-mobile/tree/main/fastlane/metadata/android/en-US/images instead, as instructed :)

@licaon-kter
Copy link

thanks

@kanishka-coder0809
Copy link
Author

So now is this issue resolved?? This means my PR is ready to be merged?

@licaon-kter
Copy link

licaon-kter commented Nov 18, 2024

We can hope

@kanishka-coder0809
Copy link
Author

Thanks for the guidance.. by the way!!

@kanishka-coder0809
Copy link
Author

Hello @licaon-kter I would like to know that if someone could just review my pull request and merge it, if possible.

@gnprice
Copy link
Member

gnprice commented Nov 26, 2024

Hi @kanishka-coder0809, welcome. Where did you obtain the image file used in this PR?

For a version we'll merge, there'll need to be a clear explanation of how the image file was produced and how it relates to the many other versions of the Zulip logo we already have. The simplest solution is to just copy one of the existing files.

Before we can merge a change it'll also need to meet our Git style guide. This change should be a single commit with an appropriate commit message. See that document for details on an appropriate commit message.

@kanishka-coder0809
Copy link
Author

Thank you for the feedback and the guidance regarding the PR. @gnprice

The image file was initially downloaded from the web, but I reproduced it to ensure it aligns with the project's standards. After creating the image, I added it to the appropriate location in the repository following the structure provided after cloning the repo.

I will make the necessary adjustments to meet the Git style guide, including consolidating the changes into a single commit with a proper commit message. Let me know if there are any additional steps or specific requirements for the image or the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon.png to fastlane en-US images
3 participants