Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: Open to unreads from summary notification. #5472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Aug 22, 2022

  1. notifications: Open to unreads from summary notification

    Adds an intent to the summary notification. When the summary
    notification is clicked in the collapsed state, the app will open and
    reset itself to the unreads screen. It will also switch to the
    appropriate account if needed.
    
    Because the intent flags (Intent.FLAG_ACTIVITY_NEW_TASK
    and Intent.FLAG_ACTIVITY_CLEAR_TOP) apply to both the normal
    notification and the summary one (and are prefaced with explanatory
    comments), I moved them to a variable before where both notifications
    are created.
    
    This was manually tested for the following cases, with both the app
    already being on the correct account and being on a different account:
    - App open in background on non-unreads screen
    - App open in background on unreads screen
    - App not open in background
    
    I also made sure that tapping on a notification in the expanded state
    still routes the user to the correct screen.
    
    Fixes zulip#5242.
    rachelhyman committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    273fae8 View commit details
    Browse the repository at this point in the history