homescreen_icon: Swap 'globe' icon with 'list' icon. #5470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2022 17:31
to allow button to consume SpecificIconType, a component type that can return a FontAwesome icon. The current component returns icons from the Feather collection. We want the new icon to be an exact match to the one found in web Zulip, which is from the FontAwesome collection, but we need the SpecificIconType component in order to do so.
to match the all-messages icon in mobile with one found on web. Performed by switching the Icon component with IconAllMessages. Fixes: #5303
|
I switched the icon to exactly the one found in web, but I wanted to bring to your attention the line width mismatch. The rest of the icons have the same aesthetic, but the new one being from a different collection doesn't quite match up with the aesthetics of the other icons. What do you think?
|
added 2 commits
August 19, 2022 18:46
to match the all-messages icon in mobile with one found on web. Performed by switching the Icon component with IconAllMessages. Fixes: #5303 merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match the all-messages icon in mobile with one found on web.
Current:
Web:
Update:
Performed by switching the Icon component with IconAllMessages.
Fixes: #5303