homescreen_tabs: Change "globe" icon to "align-left" icon. #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was made to make the All-Messages icon in mobile Zulip congruent to the one found in browser Zulip. This change was performed by changing the "name" property of the first TopTabButton component found in HomeScreen.js. This property was changed from "globe" to "align-left". It is important to note that this property is a string restricted by Flow's literal union type. A list of all valid strings for this property can be found in "FeatherGlyphs" type at the top of Icons.js. This commit has passed all included tests. Fixes: #5303.
|
There are improvements that @chrisbobbe mentioned in another PR that aren't explicitly stated in the docs. I'm closing this PR to fix it up further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made to make the All-Messages icon in mobile Zulip congruent to the one found in browser Zulip.
This swap was performed by changing the
nameproperty of the firstTopTabButtoncomponent found inHomeScreen.js. This property was changed fromglobetoalign-left. It is worthwhile to note that this property is a string restricted by Flow's literal union type. A list of all valid strings for this property can be found inFeatherGlyphstype at the top ofIcons.js.Both previous and updated icons are a part of the Feather icons collection inside the
React-Native-Vector-Icons. While it seems Zulip mobile uses Feather icons almost exclusively, if it is decided an icon from a different collection is more appropriate, changes must be made to theIconcomponent that consumes thenameproperty. In its current state, the component contains helper functions (see:fixIconType) that are configured to build only from the Feather collection.This commit has passed the included unit tests.
Fixes: #5303.