WIP: Match DNs in a case-insensitive way, always use the object's DN as found in the mock directory. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stent keys of MockLDAP.directory.
The implementation of the internal MockLDAP.directory dictionary is
defined via
self.directory = defaultdict(lambda: {})
This results in a dictionary that always returns an empty dict for any
key requested:
>>> print (self.directory['some_key'])
{}
Thus, we cannot rely on the raisal of KeyError exceptions when accessing
a non-existing LDAP DNs in the MockLDAP.directory.
Instead, we check if MockLDAP.directory['some_key'] returns an empty
dict {} value.
…und in the mock directory. LDAP DNs in LDAP servers are normally matched in a case-insensitive way. So for MockLDAP, we search our mock directory and try to find a case-insensitive match of the given DN. Saying this, we always have to return the requested DN with the capitalization as stored in our mock LDAP directory. Otherwise, MockLDAP would behave differently from live LDAP server.
|
Please wait with the PR unti #21 has been finally merged. Thanks! |
sunweaver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP DNs in LDAP servers are normally matched in a case-insensitive way. So for MockLDAP, we search our mock directory and try to find a case-insensitive match of the given DN.
Saying this, we always have to return the requested DN with the capitalization as stored in our mock LDAP directory. Otherwise, MockLDAP would behave differently from live LDAP server.
This PR includes the changes from PR #18. So, please, look at #18 first, merge it and then proceed to this PR.