-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatasetFSprovider fetchDataset() - fix behavior with non-existent datasets and members #3255
base: main
Are you sure you want to change the base?
DatasetFSprovider fetchDataset() - fix behavior with non-existent datasets and members #3255
Conversation
Signed-off-by: Benjamin Santos <[email protected]>
Signed-off-by: Benjamin Santos <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
+ Coverage 93.02% 93.05% +0.02%
==========================================
Files 113 113
Lines 11720 11731 +11
Branches 2598 2646 +48
==========================================
+ Hits 10903 10916 +13
+ Misses 815 813 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
I do recognize this is a core part of the code for the ZE data sets view. Take all the time needed for review |
Signed-off-by: Benjamin Santos <[email protected]>
Signed-off-by: Benjamin Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, I tested opening multiple data sets, both through the tree view and a virtual workspace - contents were still fetched as expected.
I noticed that the changelog entry was in the FTP extension - can you please move this to the zowe-explorer/CHANGELOG.md
file?
I'll approve this as soon as that's resolved. Thanks for the fix!
Signed-off-by: Benjamin Santos <[email protected]>
Oops 🤦♂️ I moved it. |
Proposed changes
There are currently issues for extenders with fetching MVS resources on-demand using the v3 file system. I outline them in this issue: #3252.
The proposed changes are:
items
in the API response to ensure that the requested resource actually exists, rather than just checking if the API call is completed successfullyallMembers
when fetching a member vs.dataSet
for datasetsIn the issue, Trae raised concerns about opened files in Zowe Explorer being impacted when the extension reloads or restarts - I do not see any issues with these new changes. The opened files are fetched and displayed if they are available on the host. If they were deleted via some other source, the editor will display a "The editor could not be opened because the file was not found" message, which seems appropriate.
Release Notes
Milestone: #3252
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments