Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce integrated terminal #3079

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: Introduce integrated terminal #3079

wants to merge 13 commits into from

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Aug 29, 2024

⚠️ WIP ⚠️

Proposed changes

Introduces the MVS, TSO, and Unix command handlers as integrated terminals

Release Notes

Milestone: 3.1.0

Changelog: Introduces the MVS, TSO, and Unix command handlers as integrated terminals

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

TODO:

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 119 lines in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (37a5102) to head (978ff99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/zowe-explorer/src/tools/ZoweTerminal.ts 25.53% 70 Missing ⚠️
...s/zowe-explorer/src/commands/UnixCommandHandler.ts 59.42% 28 Missing ⚠️
.../zowe-explorer/src/commands/ZoweCommandProvider.ts 85.56% 14 Missing ⚠️
...es/zowe-explorer/src/commands/TsoCommandHandler.ts 80.76% 5 Missing ⚠️
...es/zowe-explorer/src/commands/MvsCommandHandler.ts 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   92.97%   92.02%   -0.96%     
==========================================
  Files         113      114       +1     
  Lines       11661    11621      -40     
  Branches     2617     2483     -134     
==========================================
- Hits        10842    10694     -148     
- Misses        817      925     +108     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 self-assigned this Aug 29, 2024
@adam-wolfe adam-wolfe added this to the v3.1.0 milestone Sep 3, 2024
@zFernand0 zFernand0 mentioned this pull request Sep 5, 2024
15 tasks
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
22.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

}
public formatCommandLine(command: string, profile?: imperative.IProfileLoaded): string {
const prof = this.nodeProfile ?? profile;
const user: string = prof?.profile.user ?? prof.profile.user;

Check warning

Code scanning / CodeQL

Identical operands Warning

Operands
prof?.profile.user
and
prof.profile.user
are identical.
@@ -10,7 +10,7 @@
*/

import { useEffect, useState } from "preact/hooks";
import { VSCodeDivider, VSCodePanels, VSCodePanelTab } from "@vscode/webview-ui-toolkit/react";
import { VSCodeDataGridCell, VSCodeDataGridRow, VSCodeDivider, VSCodePanels, VSCodePanelTab } from "@vscode/webview-ui-toolkit/react";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports VSCodeDataGridCell, VSCodeDataGridRow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants