Add TypeScript Conversion Plugin Loader #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Shandilya <[email protected]>
ParthS007
force-pushed
the
plugin-loader-typescript
branch
from
8ce542b
to
9a55f89
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
1000TurquoisePogs
requested changes
Jun 17, 2020
lib/plugin-loader.ts
Outdated
| } | ||
| } | ||
|
|
||
| const plugInConstructorsByType = { |
There was a problem hiding this comment.
This is very similar in concept to an enum, so maybe it should be made into one.
There was a problem hiding this comment.
Can you please check now, there were some errors in below makePlugin after adding enum.
Signed-off-by: Parth Shandilya <[email protected]>
ParthS007
force-pushed
the
plugin-loader-typescript
branch
from
bee2bac
to
c209e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.