Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test vsam stcs tabs #247

Open
wants to merge 8 commits into
base: v2.x/staging
Choose a base branch
from
Open

Test vsam stcs tabs #247

wants to merge 8 commits into from

Conversation

Himani1519
Copy link
Contributor

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Himani Pathak added 2 commits August 23, 2024 00:52
added test for vsam and stcs tabs
59bdf13 
Signed-off-by: Himani Pathak <[email protected]>
minor change
e4b3577 
Signed-off-by: Himani Pathak <[email protected]>
struga0258
struga0258 reviewed Aug 28, 2024
View reviewed changes
playwright_test/Tests/Stcs.spec.ts Outdated
await electronApp.close()
})

test('test title of page', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test and "test all required fields' Should be one test. Not necessary to constantly run this every time.

playwright_test/Tests/Stcs.spec.ts Outdated
await expect(stcsPage.dataset_proclib).toBeTruthy()
})

test('verify yaml on zos', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It checks whether yaml also updated on zos or not

playwright_test/Tests/Stcs.spec.ts Outdated
})

test('test all required fields', async ({ page }) => {
await expect(stcsPage.zis).toBeTruthy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also check if the value match what we have passed from previous steps....

playwright_test/Tests/Stcs.spec.ts Outdated
await stcsPage.closeButton()
})

test('click Previous step button', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test and 'Test previous button is enabled' should be one test

playwright_test/Tests/Stcs.spec.ts
expect(is_prevButtonEnable).toBe(true);
})

test('Test Skip Stcs button is enable', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test and 'test click skip STCS button' should be one test

playwright_test/Tests/Stcs.spec.ts Outdated

test('verify stcs applied successfully on zos', async ({ page }) => {
await stcsPage.initializeSTC()
const command = `tsocmd "LISTDS '${config.PROC_LIB}' MEMBERS"`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this test might pass for now, but you might need to delete them first then do this to actually ensure it worked..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for that I will create a separate ticket for cleanup code.

playwright_test/Tests/Stcs.spec.ts Outdated
}
});

test('Test initialize stcs', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous test does all of this....

playwright_test/Tests/Stcs.spec.ts Outdated
expect(is_GreenCheck_Visible).toBe(false);
})

test('Test continue Button enabled after init stcs', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be tested with the top two test...

Himani Pathak and others added 6 commits August 29, 2024 23:27
@struga0258
Copy link
Contributor

The new code changes pushed in this PR break existing test, this PR is not ready for merge and needs to be fixed.

  1. You have replaced setup.js with setup.ts not sure why, but then you have renamed some of the functions which are now causing errors.
  2. We had spoke about this before but going from zos-node-accessor to node-ssh might be the easy solution but it comes with limitations that will not help us debug and test Zen properly.
  3. You have added two new test, Stcs and Vsam, but they are both missing 'prepare_enviroment'. This is probably why you didn't get the errors from setup.ts.
  4. The test also need to be improved for the new test files you added, they can be improved and test better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@struga0258 struga0258 struga0258 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
WebUI planning board
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Himani1519 @struga0258