Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump react-router and react-router-dom to 5.3.4 #268

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

timgerstel
Copy link
Contributor

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

PR Type

  • Bug fix
  • Feature
  • Other (Please indicate)

PR Checklist

  • PR completes npm run preCommit without error
  • Relevant Test cases have been added (Unit and or FVT)
  • Relevant update to CHANGELOG.md
  • PR from forked repo? Ensure Allow edits by maintaners is set.

Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@1000TurquoisePogs
Copy link
Member

The tests are broken by upgrades to the test libraries themselves and need to be updated.
For now I am merging as manual tests have shown things to be fine.
I am creating an issue in the zlux backlog about fixing this in the long run.

@1000TurquoisePogs 1000TurquoisePogs merged commit 6f49177 into v2.x/master Sep 25, 2024
6 of 9 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the deps/v2/react-router branch September 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants