Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with race condition of playerPool #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robinxb
Copy link

@robinxb robinxb commented Mar 8, 2018

There is a race condition crash with issue #58.
I added synchronized scope with operations of [self playerPool]
Since ReactNative's bridge always executes codes in asynchronous mode, this should fix the issue.

@trepidity
Copy link
Collaborator

Nice!
Have you tested this in your app?

@robinxb
Copy link
Author

robinxb commented Mar 12, 2018

Yes I've tested this in our app.

@trepidity
Copy link
Collaborator

I've merged this into unstable.
I will release it at the end of the month.

@trepidity trepidity added this to the 2018-04 milestone Mar 12, 2018
@robinxb
Copy link
Author

robinxb commented Apr 9, 2018

May I ask what's the date of releasing new version? :)

@almostintuitive
Copy link

We're also waiting for this fix :)

@almostintuitive
Copy link

This is currently our 2nd most frequent crash: https://sentry.io/share/issue/e4075aec0f8b44d5b48e8d94492f2715/

@paulmelnikow
Copy link
Collaborator

#476 was about fixing a key value, but also made some changes related to these, which involve running @synchronized(self) around releasing. I think these changes can be made additively to those, though I also want to be careful of deadlocks. I wonder if it would be better to centralize on a single lock object (self) rather than using both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants